-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve chain dot checking #480
Conversation
…warePlatform/triton into scxiao/improve_chaineddot_check
warpsPerTile(tt::DotOp dotOp, const ArrayRef<int64_t> shape, int numWarps, | ||
SmallVector<int64_t, 2> shapePerWarp) { | ||
// TODO: needs to be updated with appropriate shapePerWarp etc. | ||
static bool isChainDot(tt::DotOp &dotOp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change name to something more descriptive, for example isTransposeChainDotPattern
?
static bool isChainDot(tt::DotOp &dotOp) { | |
static bool isTransposeChainDotPattern(tt::DotOp &dotOp) { |
+cc @oplavsic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alefimov-amd. Changed accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Current check of chain dot is: is output of a
dot
is any input of anotherdot
, we consider them as chainDot, which is not accurate. This PR is to improve that as: output of adot
is the first argument of anotherdot
.