improve chain dot checking #480
Merged
+228
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warePlatform/triton into scxiao/improve_chaineddot_check
binarman
reviewed
Jan 28, 2024
| warpsPerTile(tt::DotOp dotOp, const ArrayRef<int64_t> shape, int numWarps, | ||
| SmallVector<int64_t, 2> shapePerWarp) { | ||
| // TODO: needs to be updated with appropriate shapePerWarp etc. | ||
| static bool isChainDot(tt::DotOp &dotOp) { |
There was a problem hiding this comment.
Maybe change name to something more descriptive, for example isTransposeChainDotPattern?
Suggested change
| static bool isChainDot(tt::DotOp &dotOp) { | |
| static bool isTransposeChainDotPattern(tt::DotOp &dotOp) { |
+cc @oplavsic
There was a problem hiding this comment.
Thanks @alefimov-amd. Changed accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current check of chain dot is: is output of a
dotis any input of anotherdot, we consider them as chainDot, which is not accurate. This PR is to improve that as: output of adotis the first argument of anotherdot.